Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat remaining JSON strings in RestControllerTest to avoid long lines #1282

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

osma
Copy link
Member

@osma osma commented Mar 2, 2022

Reasons for creating this PR

While working on a fix to #1254, I found out that some tests in RestControllerTest contain very long JSON strings on a single line. I need to change some of those and it's very difficult. So I decided to reformat first using this separate PR.

Link to relevant issue(s), if any

  • n/a

Description of the changes in this PR

Reformat test cases in RestControllerTest which contain long JSON strings on a single line. For some of the tests (the bottom ones) this has already been done in the past, this reformats also the remaining ones.

No functional changes.

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 2.14 milestone Mar 2, 2022
@osma osma self-assigned this Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1282 (5bd648d) into master (da1716c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1282   +/-   ##
=========================================
  Coverage     69.36%   69.36%           
  Complexity     1649     1649           
=========================================
  Files            32       32           
  Lines          4047     4047           
=========================================
  Hits           2807     2807           
  Misses         1240     1240           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1716c...5bd648d. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️

@osma osma merged commit 9dc7ea9 into master Mar 2, 2022
@osma osma deleted the fix-reformat-restcontrollertest-json branch March 2, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants