Use copy to clipboard icon from Font Awesome Free set #1309

osma · 2022-04-27T12:29:02Z

Reasons for creating this PR

In the Bootstrap 5 upgrade (#1182), we switched away from the copy to clipboard icon from Glyphicons (which had become non-free). Instead, another icon from Google Material Icons was used.

We looked at other icon sets and made a decision to use Font Awesome Free icons wherever possible. So this PR changes the copy to clipboard to the copy icon from Font Awesome. The SVG file has been slightly tweaked by adding the fill="#00748f" attribute to the top level <svg> element - this way it has the right color instead of being black.

This is how it looks in action:

EDIT: Updated image to match layout adjustments.

Link to relevant issue(s), if any

adjustment after changes made in Update to Bootstrap 5 #1182

Description of the changes in this PR

switch the clipboard.svg icon to one derived from the Font Awesome set
adjust icon alignment in CSS

Known problems or uncertainties in this PR

n/a

Checklist

phpUnit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

codecov · 2022-04-27T12:29:43Z

Codecov Report

Merging #1309 (f0d97a4) into master (1895bdf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1309   +/-   ##
=========================================
  Coverage     69.44%   69.44%           
  Complexity     1656     1656           
=========================================
  Files            32       32           
  Lines          4068     4068           
=========================================
  Hits           2825     2825           
  Misses         1243     1243

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1895bdf...f0d97a4. Read the comment docs.