Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit $.parseHTML() to avoid JS syntax error #1316

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

osma
Copy link
Member

@osma osma commented Apr 28, 2022

Reasons for creating this PR

The hierarchy in the IPTC vocabulary wasn't working - it gave a JS parse error. This PR fixes the problem by explicitly calling the jQuery function $.parseHTML() instead of relying on the magic $() function.

Link to relevant issue(s), if any

Description of the changes in this PR

  • use explicit $.parseHTML() call

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the bug label Apr 28, 2022
@osma osma added this to the 2.15 milestone Apr 28, 2022
@osma osma self-assigned this Apr 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #1316 (8782ebb) into master (712ead2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1316   +/-   ##
=========================================
  Coverage     70.36%   70.36%           
  Complexity     1649     1649           
=========================================
  Files            32       32           
  Lines          3790     3790           
=========================================
  Hits           2667     2667           
  Misses         1123     1123           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 712ead2...8782ebb. Read the comment docs.

@osma osma merged commit 964b68f into master Apr 28, 2022
@osma osma deleted the issue1270-hierarchy-syntax-error branch April 28, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript error on hierarchy sort
1 participant