Fix highlighting of the New tab after Bootstrap 5 upgrade

[osma]

Reasons for creating this PR

The New tab wasn't properly highlighted after changes made in the Bootstrap 5 upgrade (#1182). Note that the "New and deprecated" tab variant was working OK.

Before:

After:

Link to relevant issue(s), if any

• related to Update to Bootstrap 5 #1182

Description of the changes in this PR

• make sure the "active" CSS class is properly applied for the New tab
• move some variable declarations to a more proper place in the twig templates

Known problems or uncertainties in this PR

The template code for rendering the tabs is duplicated in five(!) different Twig templates: changes.twig, group-contents.twig, group-index.twig, light.twig and vocab.twig. This should really be refactored and implemented in just one place. I will open a separate issue about this.

Checklist

• phpUnit tests pass locally with my changes
• I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
• The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
• The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

[codecov]

Codecov Report

Merging #1328 (7971ff6) into master (290296c) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1328      +/-   ##
============================================
+ Coverage     70.59%   70.68%   +0.08%     
  Complexity     1646     1646              
============================================
  Files            32       32              
  Lines          3744     3786      +42     
============================================
+ Hits           2643     2676      +33     
- Misses         1101     1110       +9     

Impacted Files	Coverage Δ
model/Concept.php	83.63% <0.00%> (-0.22%)	⬇️
controller/RestController.php	22.38% <0.00%> (-0.01%)	⬇️
model/ConceptMappingPropertyValue.php	82.82% <0.00%> (+0.17%)	⬆️
model/sparql/GenericSparql.php	91.27% <0.00%> (+0.20%)	⬆️
model/sparql/JenaTextSparql.php	90.00% <0.00%> (+0.25%)	⬆️
model/resolver/WDQSResource.php	92.85% <0.00%> (+0.54%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290296c...7971ff6. Read the comment docs.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
50.0% Duplication

[kinow]

CI happy, screenshot and code look good! Thanks (again 🙇 ) @osma !

[osma]

The template code for rendering the tabs is duplicated in five(!) different Twig templates: changes.twig, group-contents.twig, group-index.twig, light.twig and vocab.twig. This should really be refactored and implemented in just one place. I will open a separate issue about this.

I opened issue #1329 about this.