Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skosmos 3: Use Apache Jena Fuseki docker image #1495

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Conversation

osma
Copy link
Member

@osma osma commented Aug 24, 2023

Reasons for creating this PR

PR #1477 by @kinow switched to the official Apache Jena Fuseki image on the master branch. The same needs to be done on the skosmos-3 branch. This PR makes the same changes for Skosmos 3.

Link to relevant issue(s), if any

Description of the changes in this PR

Known problems or uncertainties in this PR

n/a

(I decided to remove the Ubuntu base image update from this PR as it wasn't really related to the fuseki image update)

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

kinow and others added 3 commits August 24, 2023 14:01
(cherry picked from commit 4a0ad21)
(cherry picked from commit e2211e3)
@osma osma added this to the 3.0 milestone Aug 24, 2023
@osma osma self-assigned this Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c49e398) 63.89% compared to head (b236070) 63.89%.
Report is 2 commits behind head on skosmos-3.

Additional details and impacted files
@@             Coverage Diff              @@
##             skosmos-3    #1495   +/-   ##
============================================
  Coverage        63.89%   63.89%           
  Complexity        1634     1634           
============================================
  Files               32       32           
  Lines             4290     4290           
============================================
  Hits              2741     2741           
  Misses            1549     1549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osma osma force-pushed the skosmos-3-fuseki-docker branch from b236070 to 3cb4297 Compare August 30, 2023 06:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma
Copy link
Member Author

osma commented Aug 30, 2023

I removed the Ubuntu base image update from this PR, will hande that separately.

@osma osma merged commit cdcc15b into skosmos-3 Aug 30, 2023
@osma osma deleted the skosmos-3-fuseki-docker branch August 30, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants