Run Cypress under GitHub Actions & install Node dependencies in Docker image #1518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
We want to have Cypress tests for the new frontend, and those tests should be automated as much as possible. PR #1509 changed the Cypress test to run against a standardized, dockerized Skosmos and Fuseki environment. This PR takes it a step further by also running the Cypress tests under GitHub Actions as a separate job.
In addition, while making this PR, I noticed that the Node dependencies of the frontend (e.g. Bootstrap and Vue.js) were not installed by the Dockerfile (they would only be included if they had been installed in the surrounding Skosmos codebase, and in that case often the development dependencies would be included as well). So I adjusted the Dockerfile to include a separate
npm-installer
stage that only installs those Node dependencies, then they are copied over to the next stage which is the Skosmos runtime image.Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
n/a
Checklist
.sr-only
class, color contrast)