Top-level docker-compose.yml for Skosmos 3 #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moved `docker-compose.yml` to the top-level dir * fixed relative paths accordingly * removed `container_name` properties * replaced host port numbers with env variables with default values (cherry picked from commit 9a00be2)
Aligned with the new `docker-compose.yml` location (cherry picked from commit 0c0c439)
osma
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## skosmos-3 #1545 +/- ##
============================================
Coverage 70.51% 70.51%
Complexity 1642 1642
============================================
Files 32 32
Lines 4314 4314
============================================
Hits 3042 3042
Misses 1272 1272 ☔ View full report in Codecov by Sentry. |
kinow
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
docker-compose.yml was moved to the top level in PR 1512, already merged to the master branch. The same should be done for the skosmos-3 branch. This PR does just that.
Link to relevant issue(s), if any
Description of the changes in this PR
docker-compose.yml#1512 originally by @namedgraphtests/docker-compose.ymlafterdocker-compose.ymlwas moved to the top levelKnown problems or uncertainties in this PR
n/a
Checklist
.sr-onlyclass, color contrast)