-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting the language in the search bar #1629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the language on a vocab home page and then on a concept page in the same vocab will set multiple SKOSMOS_SEARCH_LANG
cookies with different paths. I'm not sure what effect this has but maybe the cookies should be cleared before setting a new one.
Otherwise everything seems to be working correctly.
…smos into issue1514-searchBarLanguage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the anylang
URL parameter is set, the value of the cookie is set to null. This should be fixed.
There is also a cypress test that fails but I don't know if the problem originates from this PR.
Otherwise everything looks good
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Link to relevant issue(s), if any
#1514
Description of the changes in this PR
Known problems or uncertainties in this PR
Needs more cypress tests
Checklist
.sr-only
class, color contrast)