SEO: long title on landing page (skosmos:serviceNameLong configuration setting)

src/model/BaseConfig.php

@@ -54,12 +54,14 @@ protected function getLiteral($property, $default=null, $lang=null)
             return $literal->getValue();
         }
 
-        // not found with selected language, try any language
-        $literal = $this->getResource()->getLiteral($property);
-        if ($literal) {
-            return $literal->getValue();
+        // not found with selected language, try to find one without a language tag
+        foreach ($this->getResource()->allLiterals($property) as $literal) {
+            if ($literal->getLang() === null) {
+                return $literal->getValue();
+            }
         }
 
+        // not found, return the default value
         return $default;
     }
 

src/model/GlobalConfig.php

@@ -289,6 +289,22 @@ public function getServiceName()
         return $this->getLiteral('skosmos:serviceName', 'Skosmos');
     }
 
+    /**
+     * Returns the long version of the service name in the requested language.
+     * @return string the long name of the service
+     */
+    public function getServiceNameLong($lang)
+    {
+        $val = $this->getLiteral('skosmos:serviceNameLong', false, $lang);
+
+        if ($val === false) {
+            // fall back to short service name if not configured
+            return $this->getServiceName();
+        }
+
+        return $val;
+    }
+
     /**
      * @return string
      */

src/view/base-template.twig

@@ -11,7 +11,6 @@
 <meta name="generator" content="Skosmos {{ request.version }}">
 <meta name="title" content="{{ block('title') }}">
 <meta property="og:title" content="{{ block('title') }}">
-<meta name="twitter:title" content="{{ block('title') }}">
 <meta name="twitter:card" content="summary">
 <link href="node_modules/bootstrap/dist/css/bootstrap.min.css" media="screen, print" rel="stylesheet" type="text/css">
 <link href="resource/css/fonts.css" media="screen, print" rel="stylesheet" type="text/css">

src/view/landing.twig

@@ -1,5 +1,6 @@
 {% set pageType = 'landing' %}
 {% extends "base-template.twig" %}
+{% block title %}{{ GlobalConfig.serviceNameLong(request.lang) }}{% endblock %}
 
 {% block content %}
 <div class="col-md-7">

tests/GlobalConfigTest.php

@@ -54,6 +54,21 @@ public function testGetServiceName()
         $this->assertEquals("Skosmos being tested", $this->config->getServiceName());
     }
 
+    public function testGetServiceNameLongEn()
+    {
+        $this->assertEquals("Skosmos being tested, long title", $this->config->getServiceNameLong('en'));
+    }
+
+    public function testGetServiceNameLongNoLanguageFallback()
+    {
+        $this->assertEquals("Skosmos-long", $this->config->getServiceNameLong('fr'));
+    }
+
+    public function testGetServiceNameLongNotSetFallback()
+    {
+        $this->assertEquals("Skosmos", $this->configWithDefaults->getServiceNameLong('en'));
+    }
+
     public function testGetBaseHref()
     {
         $this->assertEquals("http://tests.localhost/Skosmos/", $this->configWithBaseHref->getBaseHref());

tests/cypress/template/about.cy.js

@@ -8,7 +8,6 @@ describe('About page', () => {
     cy.get('title').invoke('text').should('equal', expectedTitle)
     // check that the page has title metadata
     cy.get('head meta[name="title"]').should('have.attr', 'content', expectedTitle);
-    cy.get('head meta[name="twitter:title"]').should('have.attr', 'content', expectedTitle);
     cy.get('head meta[property="og:title"]').should('have.attr', 'content', expectedTitle);
   })
   it('Contains version number information', () => {

tests/cypress/template/concept.cy.js

@@ -140,7 +140,6 @@ describe('Concept page', () => {
     cy.get('title').invoke('text').should('equal', expectedTitle)
     // check that the page has title metadata
     cy.get('head meta[name="title"]').should('have.attr', 'content', expectedTitle);
-    cy.get('head meta[name="twitter:title"]').should('have.attr', 'content', expectedTitle);
     cy.get('head meta[property="og:title"]').should('have.attr', 'content', expectedTitle);
   })
   it("doesn't contain breadcrumbs for top concepts", () => {

tests/cypress/template/error.cy.js

@@ -8,7 +8,6 @@ describe('Error page', () => {
     cy.get('title').invoke('text').should('equal', expectedTitle)
     // check that the page has title metadata
     cy.get('head meta[name="title"]').should('have.attr', 'content', expectedTitle);
-    cy.get('head meta[name="twitter:title"]').should('have.attr', 'content', expectedTitle);
     cy.get('head meta[property="og:title"]').should('have.attr', 'content', expectedTitle);
   })
   it('Contains 404 error code', () => {

tests/cypress/template/feedback.cy.js

@@ -8,7 +8,6 @@ describe('Feedback page', () => {
     cy.get('title').invoke('text').should('equal', expectedTitle)
     // check that the page has title metadata
     cy.get('head meta[name="title"]').should('have.attr', 'content', expectedTitle);
-    cy.get('head meta[name="twitter:title"]').should('have.attr', 'content', expectedTitle);
     cy.get('head meta[property="og:title"]').should('have.attr', 'content', expectedTitle);
   })
   it('Sends feedback', () => {
@@ -56,7 +55,6 @@ describe('Vocab feedback page', () => {
     cy.get('title').invoke('text').should('equal', expectedTitle)
     // check that the page has title metadata
     cy.get('head meta[name="title"]').should('have.attr', 'content', expectedTitle);
-    cy.get('head meta[name="twitter:title"]').should('have.attr', 'content', expectedTitle);
     cy.get('head meta[property="og:title"]').should('have.attr', 'content', expectedTitle);
   })
   it('Displays correct vocab option', () => {

tests/cypress/template/landing.cy.js

@@ -3,12 +3,11 @@ describe('Landing page', () => {
     // go to the Skosmos front page
     cy.visit('/')
 
-    const expectedTitle = 'Skosmos being tested'
+    const expectedTitle = 'Skosmos being tested, long title'
     // check that the page has a HTML title
     cy.get('title').invoke('text').should('equal', expectedTitle)
     // check that the page has title metadata
     cy.get('head meta[name="title"]').should('have.attr', 'content', expectedTitle);
-    cy.get('head meta[name="twitter:title"]').should('have.attr', 'content', expectedTitle);
     cy.get('head meta[property="og:title"]').should('have.attr', 'content', expectedTitle);
   })
   it('links to vocabulary home', () => {

tests/cypress/template/vocab-home.cy.js

@@ -7,7 +7,6 @@ describe('Vocabulary home page', () => {
     cy.get('title').invoke('text').should('equal', expectedTitle)
     // check that the page has title metadata
     cy.get('head meta[name="title"]').should('have.attr', 'content', expectedTitle);
-    cy.get('head meta[name="twitter:title"]').should('have.attr', 'content', expectedTitle);
     cy.get('head meta[property="og:title"]').should('have.attr', 'content', expectedTitle);
   })
   it('contains vocabulary title', () => {

tests/cypress/template/vocab-search.cy.js

@@ -9,7 +9,6 @@ describe('Vocabulary search page', () => {
       cy.get('title').invoke('text').should('equal', expectedTitle)
       // check that the page has title metadata
       cy.get('head meta[name="title"]').should('have.attr', 'content', expectedTitle);
-      cy.get('head meta[name="twitter:title"]').should('have.attr', 'content', expectedTitle);
       cy.get('head meta[property="og:title"]').should('have.attr', 'content', expectedTitle);
   })
   it('Contains correct amount of search results ', () => {

tests/testconfig.ttl

@@ -33,6 +33,7 @@
     skosmos:httpTimeout 2 ;
     # customize the service name
     skosmos:serviceName "Skosmos being tested" ;
+    skosmos:serviceNameLong "Skosmos being tested, long title"@en, "Skosmos-long" ;
     # customize the base element. Set this if the automatic base url detection doesn't work. For example setups behind a proxy.
     #skosmos:baseHref "http://localhost/Skosmos/" ;
     # interface languages available, and the corresponding system locales