-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap search bar #1650
Bootstrap search bar #1650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. The only thing I would maybe change is using a <button>
element instead of a <a>
element in dropdown toggle.
CSS changes are still missing but I noticed some things that need to be fixed at least:
- color of the dropdown menu text should be dark blue
- hover highlight should be added to dropdown menu items
- cursor should probably be something different in dropdown menu
- text disappears when clicking on dropdown menu items
- the arrow on the button should be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it looks good. I found one minor issue in the HTML template: the button
element probably shouldn't have a href
attribute.
I noticed that one Cypress test failed during CI, but the failing test was unrelated to this PR. In fact, I just fixed those flaky tests today in PR #1652 which is already merged so all should be well.
resource/js/vocab-search.js
Outdated
|
||
<div class="dropdown" id="language-selector"> | ||
<button class="btn btn-outline-secondary dropdown-toggle" | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the href
attribute is useful for a button
element?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed that from the a-element style implementation. I'll fix it and merge.
Quality Gate failedFailed conditions |
Link to relevant issue(s), if any
Description of the changes in this PR
Checklist
.sr-only
class, color contrast)