Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skosmos 2 Docker: upgrade to Ubuntu 22.04 base image and PHP 8.1 #1680

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

osma
Copy link
Member

@osma osma commented Sep 17, 2024

Reasons for creating this PR

Fix the Dockerfile that broke in Skosmos 2.18. It broke because newer EasyRdf requires PHP 8.0+ while the old Dockerfile was based on Ubuntu 20.04 that has PHP 7.4.

Based on PR #1498 which did essentially the same for the Skosmos 3 Dockerfile. (But this PR doesn't remove gettext because Skosmos 2 needs it.)

Link to relevant issue(s), if any

Description of the changes in this PR

  • upgrade the Dockerfile to Ubuntu 22.04 base image

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

Sorry, something went wrong.

@osma osma added bug maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance labels Sep 17, 2024
@osma osma added this to the 2.x milestone Sep 17, 2024
@osma osma self-assigned this Sep 17, 2024
@osma osma changed the base branch from main to skosmos-2 September 17, 2024 06:57
Copy link

sonarqubecloud bot commented Oct 1, 2024

@osma osma merged commit 6b9b380 into skosmos-2 Oct 1, 2024
6 of 9 checks passed
@osma osma deleted the issue1678-docker-ubuntu22.04-skosmos-2 branch October 1, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

Dockerfiles don't work on Skosmos 2.18
1 participant