-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1724 autocomplete result list #1726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes so far look good, although I'm not sure if the darker background is such a great idea. It looks a bit confusing IMHO.
If I may make an additional request, I think the left margin/padding of search results should be the same as in the search field. Currently they don't align very well, as shown here with a red line:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one line in the CSS that seems to be redundant, otherwise looks good to me!
Quality Gate failedFailed conditions |
Reasons for creating this PR
Reacting to user feedback
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
Checklist
.sr-only
class, color contrast)