Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1724 autocomplete result list #1726

Merged
merged 11 commits into from
Dec 19, 2024
Merged

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Dec 17, 2024

Reasons for creating this PR

Reacting to user feedback

Link to relevant issue(s), if any

Description of the changes in this PR

  • Search result list background changed to darker color
  • Search result list width according to the search field width
  • Add a scroll bar if the search result list or the languagage selection list is longer than 50% of view window height

Known problems or uncertainties in this PR

  • The layout changes need to be approved

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@joelit joelit added this to the 3.0 milestone Dec 17, 2024
@joelit joelit self-assigned this Dec 17, 2024
@joelit joelit marked this pull request as ready for review December 18, 2024 10:09
@joelit joelit requested a review from osma December 18, 2024 10:10
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes so far look good, although I'm not sure if the darker background is such a great idea. It looks a bit confusing IMHO.

If I may make an additional request, I think the left margin/padding of search results should be the same as in the search field. Currently they don't align very well, as shown here with a red line:

image

@joelit joelit requested review from miguelvaara and UnniKohonen and removed request for miguelvaara December 19, 2024 09:38
Copy link
Contributor

@UnniKohonen UnniKohonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one line in the CSS that seems to be redundant, otherwise looks good to me!

resource/css/skosmos.css Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@joelit joelit merged commit fd78acb into main Dec 19, 2024
9 of 11 checks passed
@joelit joelit deleted the issue1724-autocomplete-result-list branch December 19, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

Autocomplete result list improvements
3 participants