Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement groups view layout and styling #1729

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

UnniKohonen
Copy link
Contributor

@UnniKohonen UnniKohonen commented Dec 18, 2024

Reasons for creating this PR

Groups view in the sidebar does not currently have correct styling and sizing in Skosmos 3. This PR addresses that.

Link to relevant issue(s), if any

Description of the changes in this PR

  • Adds a new Font Awesome icon for all groups in group view
  • Fixes sidebar width and height for groups view (+ width for other sidebar views)

Addresses requirements 3.1, 3.2, 3.4 in #1704

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@UnniKohonen UnniKohonen added this to the 3.0 milestone Dec 18, 2024
@UnniKohonen UnniKohonen self-assigned this Dec 18, 2024
@UnniKohonen UnniKohonen marked this pull request as ready for review December 19, 2024 08:37
@UnniKohonen UnniKohonen requested a review from osma December 19, 2024 08:37
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UnniKohonen UnniKohonen merged commit 8c9ac99 into main Dec 19, 2024
10 of 11 checks passed
@UnniKohonen UnniKohonen deleted the issue1727-groups-view-layout branch December 19, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Issue/PR closed
Development

Successfully merging this pull request may close these issues.

Groups view layout and styling
2 participants