Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight currently selected concept in alphabetical list sidebar #1732

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

osma
Copy link
Member

@osma osma commented Dec 19, 2024

Reasons for creating this PR

The currently selected concept in the alphabetical index sidebar should be highlighted according to the design spec.
This one line CSS change implements this (issue #1563 task 1a).

Link to relevant issue(s), if any

Description of the changes in this PR

Modify CSS to make sure the currently selected concept is highlighted in the alphabetical index.

Known problems or uncertainties in this PR

None

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Dec 19, 2024
@osma osma self-assigned this Dec 19, 2024
@osma osma requested a review from UnniKohonen December 19, 2024 08:56
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.94%. Comparing base (5c6ff5a) to head (edeecf9).
Report is 67 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1732      +/-   ##
============================================
- Coverage     73.13%   70.94%   -2.20%     
+ Complexity     1958     1650     -308     
============================================
  Files            33       33              
  Lines          4769     4330     -439     
============================================
- Hits           3488     3072     -416     
+ Misses         1281     1258      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@UnniKohonen UnniKohonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@osma osma merged commit 55c966c into main Dec 19, 2024
11 of 13 checks passed
@osma osma deleted the issue1563-sidebar-alphabetical-highlight-current branch December 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Issue/PR closed
Development

Successfully merging this pull request may close these issues.

2 participants