Multiple top concepts / dct:subject of concept schemes #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge NatLibFi/master
of Concept schemes. 2. Ability to fetch and return multiple concept schemes for which a concept is a top concept in the parent hierarchy (new 'tops' key in the JSON-LD result)
|
Thanks for the PR. Looks much cleaner than the previous one :) |
|
Just a gentle reminder on this PR. @henriyli were you able to review it ? |
|
We reviewed this together with @henriyli and decided to merge it, looks good although we don't need this functionality in our own vocabularies |
|
Thanks - yes, it should be harmless for data that don't use this structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #636