-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 669 2 #671
Issue 669 2 #671
Conversation
Merge NatLibFi/master
and superproperty of a property.
Thanks. |
Hi @osma if you had time to review and merge this in the next couple of weeks that would be great. We are targeting the deployment of Skosmos to publish legal vocabularies in early january, and having this improvement in the master branch would help. |
We tested this with @henriyli and found out this imposes further constraints in addition to the I wonder if it would be easy to also check the property definitions from within the current vocabulary itself, as is the current behavior? |
Thanks for reviewing. I have modified the method so that it first queries the current vocabulary for property labels/superprops, before defaulting to the default SPARQL endpoint. |
Thanks, but that's probably not the best way to do it. The property definitions (including label and |
rather than making another SPARQL query.
OK done. |
Thank you! |
(depends on other PR "issue-669-1" to work properly)
I realize this may not be the correct way to proceed, since the commits already in issue-669-1 are also in this branch. let me know.