Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SERVICE_LOGO old constant and related code #682

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

kinow
Copy link
Collaborator

@kinow kinow commented Jan 9, 2018

Fix for issue Issue #665.

Looks like the WebController was even setting the variable in the twig template, but it was just never used.

Removed the constant, tests, and the code in the controller. phpunit tests passing fine in my local computer.

Cheers
Bruno

@osma
Copy link
Member

osma commented Jan 11, 2018

Great, thanks for the PR!

@osma osma merged commit 17456a2 into NatLibFi:master Jan 11, 2018
@osma osma mentioned this pull request Jan 11, 2018
@osma osma added this to the 2.0 milestone Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants