Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed concept and externalMappingProperty resource data as JSON-LD to page source #673 #674 #689

Merged
merged 9 commits into from
Jan 29, 2018
Merged

Embed concept and externalMappingProperty resource data as JSON-LD to page source #673 #674 #689

merged 9 commits into from
Jan 29, 2018

Conversation

kouralex
Copy link
Contributor

Fixes issues #673 #674

@kouralex kouralex requested review from osma and henriyli January 23, 2018 11:58
henriyli
henriyli approved these changes Jan 23, 2018
View reviewed changes
Copy link
Collaborator

@henriyli henriyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor niggle: could the $DEFAULT_EXT_PROPERTIES class variable contain prefixed short property URIs instead?

Looks good to me otherwise.

@osma
Copy link
Member

osma commented Jan 25, 2018

Agree with @henriyli. All long URIs should be changed to short CURIEs and the necessary additional prefix declarations added to Model.php

@henriyli henriyli merged commit 439a577 into master Jan 29, 2018
@henriyli henriyli deleted the concept-graph-jsonld-external branch January 30, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henriyli henriyli henriyli approved these changes

@osma osma osma approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kouralex @osma @henriyli