Issue #661 add a copy to clipboard button

[kinow]

Just wanted to learn how it was done in JS. First tried zeroclipboard as I thought that's what GitHub was using, but the flash hidden component was failing. Then tried the simplest example provided in the issue #661.

Here's the result:

It re-uses the function to make a selection. So the example code provided is simplified, but we get the same effect in the end.

Not completely happy with final button, so happy to take any suggestions for it 👍

Bruno

[henriyli]

Great timing! We were talking about this feature earlier on the same day when you made the pull request. I think the button would be better without the border. Maybe something like this?

.copy-clipboard {
  color: #00748F;
  border-radius: 0;
  vertical-align: inherit;
  font-size: 14px;
  border: 0;
}
.copy-clipboard:hover {
  background-color: #fff;
  color: #23527c;
}
.property-value-column > .copy-clipboard {
  font-size: 24px;
}

[kinow]

Looks so much better! I'm in the airport now, disconnected until Monday. But if you'd like, feel free to update the pull request or even create a new one if necessary :-) otherwise I will update it with the your markup next week. Thanks!

[henriyli]

Thank you @kinow ! This is now merged to master. I added the css in the master branch, since I couldn't figure out the proper GitHub workflow to do it.

[kinow]

Not a problem. Thanks a lot @henriyli !