Issue #737 sorting concept property values correctly #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation is true, fixes #737
…ed PHP 7.2+ build test
…vis-new-php-versions
…ures on 7.2 & fuseki SNAPSHOT
If additional fields are requested using the 'fields' parameter, add them to the JSON-LD context. Note: This will break any implementation that relies on the 'skos:' prefix being part of the keys.
…osmos into danmichaelo-test-relatedmatch
…ail optional. Fixes #761
…ific recipient has been set. Fixes #761
The cache that was created in the Model instance, now was moved to the GlobalConfig, but is still accessed from Model to add entries looked up. There is no more need of a separate .ttl file for vocabularies, as it is now part of the configuration file. Old files were removed. In order to maintain backward compatibility, most methods of GlobalConfig and of VocabularyConfig were maintained as-is. With internal changes to re-route requests to the right RDF objects. Tests were minor updates in tests, but only to replace .inc by .ttl or fix coverage annotations.
osma
requested changes
Aug 21, 2018
…i/Skosmos into henriyli-henriyli-notsort-fix-737
osma
approved these changes
Aug 27, 2018
|
There's a lot of clutter in the commit history. I will do a manual rebase before merging to verify that only the intended changes are included. |
|
Merged after manual rebase. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using natural case sort for sorting concept property values when sortByNotation is true, fixes issue #737.
This PR should undo the damage done in the previous bug fix. I had to add an extra parameter for the ConceptProperty constructor. Is this ok or should the vocabulary configuration value be passed some other way?