Automatic base url protocol detection behind reverse proxy (#905) #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmichaelo
force-pushed
the
proxy-headers
branch
from
e1a7277 to
a351230
Compare
Use the X-Forwarded-Proto header to determine the protocol when behind a TLS termination proxy.
danmichaelo
force-pushed
the
proxy-headers
branch
from
a351230 to
ea7852a
Compare
danmichaelo
changed the title
|
Thanks, and sorry for the delay! Simple and sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proxy headers (X-Forwarded-Proto and X-Forwarded-Host) to determinethe base url if configured to trust these headers (new configuration
option).
If this is merged, we also need to update https://github.com/NatLibFi/Skosmos/wiki/ConfigurationI scaled this back to just use X-Forwarded-Proto to avoid any security implications, as discussed in #905. It still solves my use case of correctly guessing the base url behind a TLS termination proxy.