Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues reported by SonarCloud #924

Merged
merged 6 commits into from
Feb 10, 2020
Merged

Fix issues reported by SonarCloud #924

merged 6 commits into from
Feb 10, 2020

Conversation

osma
Copy link
Member

@osma osma commented Feb 7, 2020

This PR should resolve all the "Bugs" and some of the "Code Smells" reported by SonarCloud. Fixes #916

There's more to be done in this area, but at least this PR takes care of the low hanging fruit.

@osma osma added this to the 2.3 milestone Feb 7, 2020
@osma osma requested a review from kouralex February 7, 2020 13:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #924 into master will increase coverage by 0.09%.
The diff coverage is 56.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #924      +/-   ##
============================================
+ Coverage     57.68%   57.78%   +0.09%     
  Complexity     1489     1489              
============================================
  Files            32       32              
  Lines          4178     4164      -14     
============================================
- Hits           2410     2406       -4     
+ Misses         1768     1758      -10
Impacted Files Coverage Δ Complexity Δ
controller/Controller.php 13.48% <0%> (+0.29%) 38 <0> (ø) ⬇️
model/Model.php 80.32% <0%> (+0.32%) 105 <0> (ø) ⬇️
controller/RestController.php 3.99% <0%> (+0.01%) 147 <0> (ø) ⬇️
controller/WebController.php 17.75% <0%> (+0.04%) 95 <0> (ø) ⬇️
model/ConceptSearchParameters.php 84.26% <100%> (-0.18%) 58 <0> (ø)
controller/Honeypot.php 38.46% <100%> (-2.28%) 11 <0> (ø)
model/ConceptMappingPropertyValue.php 72.32% <100%> (-0.49%) 41 <0> (ø)
model/ConceptPropertyValue.php 79.26% <100%> (-0.25%) 46 <0> (ø)
model/Concept.php 79.31% <66.66%> (+0.09%) 184 <0> (ø) ⬇️
model/resolver/LinkedDataResource.php 93.33% <0%> (+20%) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13dee7...c13fd51. Read the comment docs.

@osma osma merged commit 8b34b23 into master Feb 10, 2020
@osma osma deleted the issue916-sonarcloud-issues branch February 11, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and address code quality issues flagged by SonarCloud
1 participant