Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added copy to clipboard button for a notation in the title bar #925

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Feb 7, 2020

Fixes #832

@joelit joelit requested a review from kouralex February 7, 2020 13:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #925 into master will increase coverage by 7.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #925      +/-   ##
============================================
+ Coverage     57.68%   65.04%   +7.36%     
+ Complexity     1489     1488       -1     
============================================
  Files            32       32              
  Lines          4178     3705     -473     
============================================
  Hits           2410     2410              
+ Misses         1768     1295     -473
Impacted Files Coverage Δ Complexity Δ
model/resolver/LOCResource.php 0% <0%> (ø) 6% <0%> (ø) ⬇️
model/resolver/WDQSResource.php 0% <0%> (ø) 3% <0%> (ø) ⬇️
controller/Controller.php 13.48% <0%> (+0.29%) 38% <0%> (ø) ⬇️
controller/RestController.php 4.53% <0%> (+0.55%) 147% <0%> (ø) ⬇️
model/Request.php 67.07% <0%> (+0.8%) 50% <0%> (ø) ⬇️
model/ConceptPropertyValue.php 80.48% <0%> (+0.96%) 46% <0%> (ø) ⬇️
model/PluginRegister.php 70.14% <0%> (+1.03%) 28% <0%> (ø) ⬇️
model/Vocabulary.php 88.23% <0%> (+1.09%) 107% <0%> (ø) ⬇️
model/ConceptPropertyValueLiteral.php 62.5% <0%> (+1.52%) 17% <0%> (ø) ⬇️
controller/Honeypot.php 42.3% <0%> (+1.56%) 11% <0%> (ø) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13dee7...c91382c. Read the comment docs.

@kouralex kouralex merged commit e993a89 into master Feb 10, 2020
@kouralex kouralex added this to the 2.3 milestone Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy-to-Clipboard for skos:notation when it is displayed in Classification class view
2 participants