Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information about Wikidata sitelinks to enable wiki widget #928

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

osma
Copy link
Member

@osma osma commented Feb 10, 2020

Fixes #927

@osma osma added the bug label Feb 10, 2020
@osma osma added this to the 2.3 milestone Feb 10, 2020
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #928 into master will decrease coverage by 0.41%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #928      +/-   ##
============================================
- Coverage     57.68%   57.26%   -0.42%     
  Complexity     1489     1489              
============================================
  Files            32       32              
  Lines          4178     4184       +6     
============================================
- Hits           2410     2396      -14     
- Misses         1768     1788      +20
Impacted Files Coverage Δ Complexity Δ
model/resolver/WDQSResource.php 0% <0%> (ø) 3 <0> (ø) ⬇️
model/DataObject.php 73.17% <0%> (-2.44%) 23% <0%> (ø)
model/ConceptPropertyValue.php 78.31% <0%> (-1.21%) 46% <0%> (ø)
model/Model.php 78.8% <0%> (-1.21%) 105% <0%> (ø)
model/Concept.php 78.42% <0%> (-0.79%) 184% <0%> (ø)
model/VocabularyConfig.php 92.69% <0%> (-0.57%) 73% <0%> (ø)
model/sparql/GenericSparql.php 67.62% <0%> (-0.45%) 302% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e993a89...6cb9c0c. Read the comment docs.

@osma osma merged commit b0b13ec into master Feb 10, 2020
@osma osma deleted the issue927-wdqs-wiki-widget branch February 11, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wikipedia widget not working after switching to WDQS endpoint
1 participant