Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #934 #946

Merged
merged 1 commit into from
Mar 4, 2020
Merged

fixes #934 #946

merged 1 commit into from
Mar 4, 2020

Conversation

kouralex
Copy link
Contributor

@kouralex kouralex commented Mar 4, 2020

This PR fixes #934 pretty straightforward except for

1) ConceptPropertyTest::testAddValue
This test did not perform any assertions
/skosmos/tests/ConceptPropertyTest.php:79

2) ConceptTest::testGetPropertiesAlphabeticalSortingOfPropertyValues
This test did not perform any assertions
/skosmos/tests/ConceptTest.php:178

Both of which require a more detailed intervention and changes in logic. One can see #938 for example implementation.

@kouralex kouralex requested a review from osma March 4, 2020 12:01
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
17.6% 17.6% Duplication

@osma osma added this to the 2.4 milestone Mar 4, 2020
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One of the Travis build jobs (PHP 7.3) failed, probably due to a transient issue. I restarted it. When it finishes, this can be merged.

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #946 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #946      +/-   ##
============================================
+ Coverage     58.38%   58.45%   +0.07%     
  Complexity     1486     1486              
============================================
  Files            32       32              
  Lines          4162     4162              
============================================
+ Hits           2430     2433       +3     
+ Misses         1732     1729       -3
Impacted Files Coverage Δ Complexity Δ
model/Model.php 81.52% <0%> (+1.2%) 105% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd37701...9054b74. Read the comment docs.

@kouralex kouralex merged commit 2d5e4df into master Mar 4, 2020
@osma osma deleted the issue934-clean-phpunit-output branch March 12, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running PHPUnit tests causes extra output
2 participants