Fix static analysis issues

[kinow]

Left multiple commits for now in-case we need to drop some. But happy to squash (or OK if somebody else squashes them) commits. Had some time today while another thing was running, so went through the code, the static analysis issues reported in SonarCloud and PhpStorm and fixed a few ones.

Cheers
Bruno

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[kinow]

Hm, not sure why that unit test failed. Can't tell if related to this change or not.

[osma]

Thanks @kinow! Looks good! I will test locally and if everything works fine after the changes, I will merge this. No need to squash - it's good to have small, descriptive commits.

One of the Travis jobs failed, probably just some random transient issue. I restarted it.

[codecov]

Codecov Report

Merging #968 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #968      +/-   ##
============================================
- Coverage     58.80%   58.79%   -0.02%     
  Complexity     1505     1505              
============================================
  Files            32       32              
  Lines          4207     4208       +1     
============================================
  Hits           2474     2474              
- Misses         1733     1734       +1     

Impacted Files	Coverage Δ	Complexity Δ
controller/Controller.php	13.33% <0.00%> (-0.15%)	38.00 <0.00> (ø)
controller/WebController.php	17.75% <ø> (ø)	95.00 <0.00> (ø)
model/Model.php	81.52% <ø> (ø)	105.00 <0.00> (ø)
model/VocabularyConfig.php	92.30% <ø> (ø)	75.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17361d5...aac5f85. Read the comment docs.

[osma]

Couldn't find any issues, and the Travis CI job passed on the second attempt. Thanks again!