Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST API methods for alphabetical index #976

Merged
merged 8 commits into from
May 6, 2020

Conversation

osma
Copy link
Member

@osma osma commented May 5, 2020

Fixes #599

This adds two methods to the REST API:

/rest/v1/<vocab>/index/?lang=<language> -> list of letters available in the vocabulary alphabetical index, in the given language
/rest/v1/<vocab>/index/<letter>?lang=<language> -> list of terms/concepts for that letter in the vocabulary alphabetical index

Still TODO:

  • implement limit and offset parameters
  • update Swagger / OpenAPI spec
  • address QA issues, if any

@osma osma added this to the 2.6 milestone May 5, 2020
@osma osma added the REST label May 5, 2020
@osma osma self-assigned this May 5, 2020
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #976 into master will increase coverage by 0.11%.
The diff coverage is 74.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #976      +/-   ##
============================================
+ Coverage     58.97%   59.08%   +0.11%     
- Complexity     1511     1517       +6     
============================================
  Files            32       32              
  Lines          4232     4263      +31     
============================================
+ Hits           2496     2519      +23     
- Misses         1736     1744       +8     
Impacted Files Coverage Δ Complexity Δ
controller/RestController.php 7.89% <74.19%> (+3.90%) 153.00 <6.00> (+6.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af793fc...f025b98. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma osma marked this pull request as ready for review May 5, 2020 13:28
@osma osma requested a review from joelit May 5, 2020 13:28
Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I appreciate the thoroughness of the RestController tests.

@joelit joelit merged commit e821af0 into master May 6, 2020
@osma osma deleted the issue599-rest-alphabetical-index branch May 6, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add REST API method for alphabetical index
2 participants