Initial draft for listing new and modified concepts for a vocabulary in the REST API

[joelit]

Output can be seen e.g.
curl -X GET --header 'Accept: application/json' http://localhost/Skosmos/rest/v1/yso/modifiedConcepts?lang=en'

[codecov]

Codecov Report

Merging #982 into master will increase coverage by 6.08%.
The diff coverage is 58.82%.

@@             Coverage Diff              @@
##             master     #982      +/-   ##
============================================
+ Coverage     59.12%   65.20%   +6.08%     
- Complexity     1548     1829     +281     
============================================
  Files            32       32              
  Lines          4335     5280     +945     
============================================
+ Hits           2563     3443     +880     
- Misses         1772     1837      +65     

Impacted Files	Coverage Δ	Complexity Δ
controller/RestController.php	11.45% <34.78%> (+0.89%)	189.00 <17.00> (+17.00)
controller/WebController.php	14.98% <64.28%> (+8.47%)	83.00 <3.00> (+6.00)
model/sparql/GenericSparql.php	74.53% <91.66%> (+6.12%)	438.00 <3.00> (+121.00)
model/Vocabulary.php	86.80% <100.00%> (-0.26%)	112.00 <1.00> (-1.00)
model/ConceptProperty.php	96.29% <0.00%> (+0.46%)	28.00% <0.00%> (+11.00%)
model/Concept.php	82.08% <0.00%> (+2.28%)	253.00% <0.00%> (+66.00%)
model/VocabularyConfig.php	95.62% <0.00%> (+2.55%)	142.00% <0.00%> (+61.00%)
controller/Honeypot.php	46.15% <0.00%> (+7.69%)	11.00% <0.00%> (ø%)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80fad12...a907434. Read the comment docs.

[osma]

This is how the JSON output of modifiedConcepts currently looks:

Some observations:

• JSON-LD context is missing for most fields/properties
• The results are grouped by month, as they are shown in the UI. I think that is unnecessary in a REST API. It would be better to just return a flat list.
• The dates are very complex objects with several fields. It would be better to just return ISO 8601 datetime strings such as 2020-05-04T02:44:12+00:00, which can then be assigned the xsd:dateTime data type in the JSON-LD context

[osma]

Some rather minor remarks

[osma]

Other comments on the PR:

• Swagger spec still needs to be done
• I wonder if the methods should support setting limit and offset, like some other REST methods (e.g. search, index/X)

[osma]

Scrutinizer complains about the getChangeList method docstring:

• @param string $lang UI language for the dates
  There is no parameter named $lang. Was it maybe removed?

Method signature:

public function getChangeList($prop, $clang, $offset, $limit)

[osma]

Postponing to the next release, will release 2.6 without this PR since there are still things to improve

[osma]

Still a few things to improve/fix, but looking pretty good now

[osma]

A couple of minor phpdoc bugs, otherwise ready for merging

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
7 Code Smells

No Coverage information
0.0% Duplication