Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global REST label method #983

Merged
merged 2 commits into from
May 8, 2020
Merged

Global REST label method #983

merged 2 commits into from
May 8, 2020

Conversation

osma
Copy link
Member

@osma osma commented May 8, 2020

Fixes #952

Still missing Swagger spec. Creating a draft PR to get feedback from QA tools.

@osma osma added this to the 2.6 milestone May 8, 2020
@osma osma self-assigned this May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #983 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #983      +/-   ##
============================================
+ Coverage     59.06%   59.11%   +0.04%     
- Complexity     1546     1548       +2     
============================================
  Files            32       32              
  Lines          4329     4334       +5     
============================================
+ Hits           2557     2562       +5     
  Misses         1772     1772              
Impacted Files Coverage Δ Complexity Δ
controller/RestController.php 10.55% <100.00%> (+0.75%) 172.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610131f...8459c37. Read the comment docs.

@osma osma requested a review from joelit May 8, 2020 13:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma osma marked this pull request as ready for review May 8, 2020 13:01
@joelit
Copy link
Contributor

joelit commented May 8, 2020

I tested this locally, and it looked good!

@joelit joelit merged commit 2f28514 into master May 8, 2020
@osma osma deleted the issue952-global-rest-label branch February 17, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global REST label method
2 participants