Skip to content

Commit

Permalink
Fixing threading test reported by TSAN. (iree-org#17260)
Browse files Browse the repository at this point in the history
Found here:
https://github.com/iree-org/iree/actions/runs/8914840398/job/24483271590#step:4:14211
The thread must be joined prior to deinitializing the notification.
  • Loading branch information
benvanik authored May 1, 2024
1 parent 355f56b commit b8ef25c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion runtime/src/iree/base/internal/threading_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ TEST(ThreadTest, CreateSuspended) {
iree_memory_order_relaxed) == (123 + 1);
},
&entry_data, iree_infinite_timeout());
iree_notification_deinitialize(&entry_data.barrier);
iree_thread_release(thread);
iree_notification_deinitialize(&entry_data.barrier);
}

// NOTE: testing whether priority took effect is really hard given that on
Expand Down

0 comments on commit b8ef25c

Please sign in to comment.