Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a center instead of required on Map component. #35

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

NathanAP
Copy link
Owner

@NathanAP NathanAP commented Dec 20, 2022

This fixes #28 . I changed the required: true prop for default: { lat: 0, lng: 0 } and it seems to work. I'm not sure why Fawmi prefered to add a required instead of default. Seems to work on my example.

@NathanAP NathanAP added the bug fix I never liked bugs anyway label Dec 20, 2022
@NathanAP NathanAP self-assigned this Dec 20, 2022
@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for vue-google-maps-community-fork canceled.

Name Link
🔨 Latest commit 462679a
🔍 Latest deploy log https://app.netlify.com/sites/vue-google-maps-community-fork/deploys/63a1ab55f8359200080062c0

@NathanAP NathanAP merged commit 462679a into main Dec 21, 2022
@NathanAP NathanAP deleted the add-default-to-center-prop branch December 21, 2022 13:20
@NathanAP NathanAP removed the request for review from websitevirtuoso December 21, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix I never liked bugs anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map breaks if no :center is provided
1 participant