Skip to content

Commit

Permalink
Merge pull request #3809 from mhenkens/bugfix/3658
Browse files Browse the repository at this point in the history
fix(stark-testing): replace `@npmcli/ci-detect` dependency by `ci-info`
  • Loading branch information
SuperITMan authored Jun 4, 2024
2 parents a1fb423 + dc3eb8a commit 2d8aead
Showing 6 changed files with 100 additions and 107 deletions.
159 changes: 76 additions & 83 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -48,7 +48,6 @@
"@ngrx/store": "^16.3.0",
"@ngtools/json-schema": "^1.1.0",
"@ngx-translate/core": "^15.0.0",
"@npmcli/ci-detect": "^1.3.0",
"@release-it/conventional-changelog": "^8.0.1",
"@sqltools/formatter": "^1.2.3",
"@types/jasmine": "~5.1.4",
@@ -64,6 +63,7 @@
"@uirouter/rx": "~0.6.0",
"angular2-text-mask": "^9.0.0",
"cerialize": "^0.1.18",
"ci-info": "^4.0.0",
"class-validator": "~0.14.1",
"commitizen": "^4.2.3",
"conventional-changelog-cli": "^4.1.0",
4 changes: 2 additions & 2 deletions packages/stark-testing/karma.conf.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Helpers
const helpers = require("./helpers");
const ciDetect = require("@npmcli/ci-detect");
const isCI = process.argv.indexOf("--watch=false") > -1 || !!ciDetect();
const ci = require("ci-info");
const isCI = process.argv.indexOf("--watch=false") > -1 || !!ci.isCI;

const rawKarmaConfig = {
// base path that will be used to resolve all patterns (e.g. files, exclude)
2 changes: 1 addition & 1 deletion packages/stark-testing/package.json
Original file line number Diff line number Diff line change
@@ -21,10 +21,10 @@
},
"dependencies": {
"@angular-devkit/build-angular": "^16.2.14",
"@npmcli/ci-detect": "^1.3.0",
"@types/jasmine": "~5.1.4",
"@types/karma": "^6.3.8",
"@types/node": "^18.19.4",
"ci-info": "^4.0.0",
"jasmine-core": "^5.1.2",
"karma": "^6.4.2",
"karma-chrome-launcher": "^3.2.0",
Loading

0 comments on commit 2d8aead

Please sign in to comment.