Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build-main): disable failing MacOS runners #3463

Conversation

SuperITMan
Copy link
Member

MacOS jobs are always failing due to a GitHub limitation when downloading the GeckoDriver from GitHub for Protractor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

All the plans running on macos runners are failing due to a download, by Protractor, of GeckoDriver on GitHub.
It hits an API rate limit of GitHub: actions/runner-images#602

What is the new behavior?

We can easily see if a PR is ok if no failed jobs.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@SuperITMan SuperITMan added this to the 12.0.0-rc.0 milestone Sep 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.208% when pulling 5dad934 on SuperITMan:bugfix/ci-disable-failing-macos-runners into 6a105d7 on NationalBankBelgium:master.

@SuperITMan SuperITMan added the comp: ci & tooling CI, GitHub Actions, ... label Sep 15, 2022
@SuperITMan SuperITMan merged commit 9e90233 into NationalBankBelgium:master Sep 15, 2022
@SuperITMan SuperITMan deleted the bugfix/ci-disable-failing-macos-runners branch February 5, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: ci & tooling CI, GitHub Actions, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants