Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rxjs #3713

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Feature/rxjs #3713

merged 5 commits into from
Feb 7, 2024

Conversation

mhenkens
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

In order to update to angular 14 we need to update rxjs
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:


## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->

Issue Number: N/A

## What is the new behavior?

## Does this PR introduce a breaking change?

[x] Yes
[ ] No


breaking change related to `rxjs` 

## Other information

@SuperITMan SuperITMan self-requested a review January 30, 2024 09:39
@SuperITMan SuperITMan added comp: stark-all To apply for all Stark modules type: feature dependencies Pull requests that update a dependency file labels Jan 30, 2024
@SuperITMan SuperITMan added this to the 12.0.0-beta.1 milestone Jan 30, 2024
@coveralls
Copy link

coveralls commented Jan 30, 2024 •
edited
Loading

Coverage Status

coverage: 88.609% (-0.01%) from 88.619%
when pulling e5d9b74 on mhenkens:feature/rxjs
into 3defd41 on NationalBankBelgium:master.

SuperITMan
SuperITMan reviewed Jan 30, 2024
View reviewed changes
packages/stark-ui/src/modules/toast-notification/services/toast-notification.service.ts
@@ -23,7 +23,7 @@ export class StarkToastNotificationServiceImpl implements StarkToastNotification
/**
* Observer linked to the currently displayed toast notification
*/
public currentToastResult$?: Observer<StarkToastNotificationResult>;
private currentToastResult$?: Observer<StarkToastNotificationResult>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing this from public to private ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we refactor and this due to the fact the Oberver interface do not contain closed property anymore

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

SuperITMan
SuperITMan approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@SuperITMan SuperITMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SuperITMan SuperITMan merged commit 0d359d6 into NationalBankBelgium:master Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperITMan SuperITMan SuperITMan approved these changes

Assignees
No one assigned
Labels
comp: stark-all To apply for all Stark modules dependencies Pull requests that update a dependency file type: feature
Projects
None yet
Milestone
12.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mhenkens @coveralls @SuperITMan