-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy snpseq metadata service #237
Deploy snpseq metadata service #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had a couple questions about the metadata package.
@@ -0,0 +1,19 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why the snpseq_metadata package is not installed as a dependency of the snpseq_metadata service?
And also, shouldn't you download the ENA/SRA xml schema after installing the package here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not other than I opted for not creating a separate role for snpseq_metadata
since it will likely only be used by this service and also installed in the same environment, so I figured I could just as well deploy them together.
good catch about the schema, I will definitely need that, yes 🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...or I guess you maybe mean that it should be a python dependency? that could perhaps be an option, not sure how straightforward it would be to run the post-install stuff but I guess there's probably hooks for that in pyproject
... actually, no - that seems not to be possible (by design)
Pontus and I talked about it and decided to pull this into this month's release. It shouldn't break anything else and it would be nice to have it there for testing. |
This deploys the
snpseq-metadata-service
andsnpseq_metadata
package to miarka.Before merging, the actual
snpseq-metadata-service
andsnpseq_metadata
package versions need to be updated to the latest versions.