Javadoc JDK 13 Compatibility (HTML5)

[astrelsky]

This is merely for documentation purposes.

The option --no-module-directories has been removed from javadoc. info
There are also numerous errors due to bad usage of > and <.

I will edit this with more information later today.

[ryanmkurtz]

I'm going to consider this an enhancement since we officially support JDK 11 LTS. I'll look into it though.

[astrelsky]

I'm going to consider this an enhancement since we officially support JDK 11 LTS. I'll look into it though.

I just figured it best to open the issue and document it. Would there be any issues with changing html to html5? ie changing name attributes to id and such.

I'm currently going through and fixing minor mistake with angle brackets and wrong links.

[ryanmkurtz]

Yes we definitely appreciate the issue being reported. --no-module-directories was put in to address #129. If there is a better solution out there we'll put it in!

[astrelsky]

Yes we definitely appreciate the issue being reported. --no-module-directories was put in to address #129. If there is a better solution out there we'll put it in!

I'll look into another solution after class this afternoon. I have most of the html errors and outdated links out of the way already.

[astrelsky]

Yes we definitely appreciate the issue being reported. --no-module-directories was put in to address #129. If there is a better solution out there we'll put it in!

According to the openjdk bug report this was fixed in JDK 12. Since JDK 11 LTS is what is officially supported and the bug only exists in Java11 I've simply added a check in distribution.gradle to apply the option only if it is Java11.

I'll submit a pr along with a bunch of fixes for javadoc errors.

Also getting javadoc: error - invalid flag: -notimestamp. I've tried adding the following to the createJavadocs task but it seemed to raise the same error whether I set it to true or false.

options.setNoTimestamp​(false)

[astrelsky]

It appears the -notimestamp is occuring in the createJsondocs task. Adding setNoTimestamp(false) to the task fixes the error there and I've confirmed it is available in gradle 5.0.