Adds an address space id field to BSim objects #6897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te all related functions for BSIM add missing fix for abstract bsim apply task
je0xffrey
changed the title
je0xffrey
changed the title
je0xffrey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6896 for the bug that this PR is addressing.
These changes intend to make BSim more friendly for querying binaries that have multiple overlay address spaces. It accomplishes this by adding the
spaceidfield to a number of objects that are used by BSim, such as theFunctionDescriptionandCallRecord. Thisspaceidfield represents the Address Space ID and it is used to retrieve the original Address Space of the function. By combining the Address Space with the longoffset(the address that is currently being stored) we now have all the information we need to reliably retrieve functions for comparison.Backwards Compatibility
I want to note that this solution creates an issue of backwards compatibility with existing BSim servers. This is because I added a new column to the
desctableto store the address space id with the functions offset. Querying a database that has not been created by the updated version of the client would cause errors as that column would be missing. I'm unsure of the best step forward to resolve this concern, but I would be interested in speaking about potential options like using theDatabaseInformationobject to check for compatibility.