Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kill tree php server #157

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

SRWieZ
Copy link
Contributor

@SRWieZ SRWieZ commented Jan 16, 2025

For unknown reasons, PHP server child processes will persists when closing NativePHP app CMD+Q

It doesn't happens when using CTRL+C on php artisan native:serve.

The only difference I see is that CTRL+C send an SIGINT, instead of a graceful SIGTERM.

From my research:

  • SIGINT for immediate interruption (user-driven).
  • SIGTERM for a graceful termination (programmatic request).

@simonhamp simonhamp merged commit b0718db into NativePHP:main Jan 21, 2025
11 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants