Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Prompts to request Platform when not provided #92

Merged
merged 3 commits into from
May 4, 2024
Merged

Use Prompts to request Platform when not provided #92

merged 3 commits into from
May 4, 2024

Conversation

vikas5914
Copy link
Contributor

No description provided.

@vikas5914 vikas5914 mentioned this pull request May 4, 2024
Closed
simonhamp
simonhamp requested changes May 4, 2024
View reviewed changes
Copy link
Member

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a good quality of life improvement, just needs a little more to make it great

src/Commands/BuildCommand.php Outdated Show resolved Hide resolved
src/Commands/BuildCommand.php Outdated Show resolved Hide resolved
vikas5914 and others added 2 commits May 4, 2024 23:54
@vikas5914 @simonhamp
Update src/Commands/BuildCommand.php
1c815f7 
Co-authored-by: Simon Hamp <simon.hamp@me.com>
@vikas5914
Update BuildCommand.php
025bbd0
@vikas5914 vikas5914 changed the title Use Promote to request Platform when not provided Use Prompts to request Platform when not provided May 4, 2024
simonhamp
simonhamp approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Thanks 🙏🏼

@simonhamp simonhamp merged commit ab2fd13 into NativePHP:main May 4, 2024
1 of 9 checks passed
@vikas5914 vikas5914 deleted the patch-1 branch May 5, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhamp simonhamp simonhamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikas5914 @simonhamp