Create Native\Laravel\Facades\Notification #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mombuyish
changed the title
milwad-dev
reviewed
Jul 21, 2023
| namespace Native\Laravel\Facades; | ||
|
|
||
| use Illuminate\Support\Facades\Facade; | ||
|
|
There was a problem hiding this comment.
Add notification methods into docblock!
There was a problem hiding this comment.
Just Object_ is a problem!
I fix it after this PR
simonhamp
reviewed
Jul 22, 2023
|
I fixed all of suggestions and import failed class. |
I wanted to get rid of all these static constructors as they hide the Client dependency. That's why this was also removed in most other classes - so I think a facade is better suited in this case 👍 |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to doc: https://nativephp.com/docs/1/the-basics/notifications that it needs Facade for notification, but missing now.