Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for MenuBar #31

Merged
merged 4 commits into from
Jul 29, 2023
Merged

Conversation

milwad-dev
Copy link
Contributor

When we didn't install http guzzle you can't use Client because shows an error message: Class "GuzzleHttp\HandlerStack" not found!

Also, MenuBar tests completely.
Coverage: 100%

@mpociot
Copy link
Member

mpociot commented Jul 21, 2023

The client makes use of the HTTP facade though, so it shouldn't be required to manually depend on guzzle 🤔

@milwad-dev
Copy link
Contributor Author

I say if remove Guzzle throw an error! What we doing!

@mpociot mpociot merged commit 8540706 into NativePHP:main Jul 29, 2023
@milwad-dev milwad-dev deleted the add-tests-for-menubar branch July 30, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants