Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] Slider value is overridden when min/maxValue properties are set #4343

Closed
manoldonev opened this issue Jun 8, 2017 · 1 comment · Fixed by #4346
Closed

[Angular] Slider value is overridden when min/maxValue properties are set #4343

manoldonev opened this issue Jun 8, 2017 · 1 comment · Fixed by #4346
Assignees
Labels

Comments

@manoldonev
Copy link
Contributor

Which platform(s) does your issue occur on?

Android

Please provide the following version numbers that your issue occurs with:

  • CLI: 3.0.3
  • Cross-platform modules: 3.1.0-2017-06-08-6861
  • Runtime(s): tns-android 3.0.1

Please tell us how to recreate the issue in as much detail as possible.

Setting declaratively (or binding) minValue / maxValue properties resets the slider value to minValue. Slider value can be set declaratively or via binding -- it does not matter, result is the same. This works correctly on iOS.

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

The issue is reproducible with some of the sliders in the Angular sdk examples here.
Btw, slider-examples.module.ts in the sdk examples repo is missing reference to NativeScriptFormsModule so out-of-the-box all bindings in the slider example do not work.

Each of the sliders in this example is initialized with slider value != minValue but when example is loaded some slider values erroneously are set to minValue on Android:
screenshot_1496932464

In iOS everything works:
simulator screen shot jun 8 2017 5 30 20 pm

@manoldonev manoldonev added the bug label Jun 8, 2017
@sis0k0 sis0k0 self-assigned this Jun 8, 2017
sis0k0 added a commit that referenced this issue Jun 8, 2017
The setter should invoke setNativeValuesSilently with the new value and
max value respectively.

fixes #4343
sis0k0 added a commit that referenced this issue Jun 9, 2017
The setter should invoke setNativeValuesSilently with the new value and
max value respectively.

fixes #4343
sis0k0 added a commit that referenced this issue Jun 9, 2017
The setter should invoke setNativeValuesSilently with the new value and
max value respectively.

fixes #4343
@lock
Copy link

lock bot commented Aug 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants