Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sorting issue with Css Selectors with same specificity. #2310

Merged
merged 1 commit into from
Jun 17, 2016

Conversation

nsndeck
Copy link

@nsndeck nsndeck commented Jun 14, 2016

In some cases when a lot css selectors are used unstable sort of CssSelectors results in problems with correct order of applying css selectors.

@@ -134,3 +134,36 @@ export function isDataURI(uri: string): boolean {

return firstSegment && firstSegment.indexOf("data:") === 0 && firstSegment.indexOf('base64') >= 0;
}

export function mergeSort(arr, compareFunc) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting we rename this to stableSort to make it obvious why we need it :)

@nsndeck nsndeck force-pushed the nnikolov/CssSelectorsSameSpecifityFix branch from 8a2d39a to ba3a26d Compare June 15, 2016 08:12
@vchimev
Copy link
Contributor

vchimev commented Jun 15, 2016

run ci

2 similar comments
@nsndeck
Copy link
Author

nsndeck commented Jun 17, 2016

run ci

@dtopuzov
Copy link
Contributor

run ci

@nsndeck nsndeck force-pushed the nnikolov/CssSelectorsSameSpecifityFix branch from ba3a26d to 9ac40a5 Compare June 17, 2016 10:34
@nsndeck nsndeck merged commit 33dd9a6 into master Jun 17, 2016
@nsndeck nsndeck deleted the nnikolov/CssSelectorsSameSpecifityFix branch June 17, 2016 10:59
@hshristov hshristov added this to the 2.1 milestone Jul 1, 2016
@lock
Copy link

lock bot commented Aug 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants