fix(android): crash on changing activity context after animated navigation Fixes #5674 #5700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation with transition
ghost
added
the
manoldonev
commented
Apr 18, 2018
| if (this._currentEntry && this._currentEntry.fragment) { | ||
| const manager: android.app.FragmentManager = this._getFragmentManager(); | ||
| const transaction = manager.beginTransaction(); | ||
| private disposeCurrentFragment(): void { |
There was a problem hiding this comment.
We need the disposeCurrentFragment() call because of this: [quoting @MartoYankov] in Tabs-Frames-Pages scenario all of the frames' fragments are restored before the tabs' fragments are recreated and they try to load their pages before they have been selected. The chosen solution was to remove the frame fragment on unloading the frame. We want Android to recreate the tab fragment that will load its frame (that creates a new fragment for the page).
vakrilov
approved these changes
Apr 19, 2018
MartoYankov
approved these changes
Apr 19, 2018
|
tests for api level 21 & 22 executed here: #5712 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5674
Fixes Android Lollipop (API Level 21 and 22) crash on changing activity context (e.g. starting external activity with
utils.openurl(...)call or minimizing app) after navigation with animated transition has been executed within the app.