suppress deprecation warnings in generated code

NativeScript · Jun 13, 2019 · 2b800fd · 2b800fd
1 parent 72a44e4
commit 2b800fd
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 4 deletions.
diff --git a/test-app/app/build.gradle b/test-app/app/build.gradle
@@ -411,6 +411,12 @@ task addDependenciesFromAppResourcesLibraries {
  }
 }
 
+// Uncomment the code bellow to get detailed deprecation warnings
+//tasks.withType(JavaCompile) {
+// options.compilerArgs << '-Xlint:unchecked'
+// options.deprecation = true
+//}
+
 tasks.whenTaskAdded({ org.gradle.api.DefaultTask currentTask ->
  if (currentTask =~ /generate.+BuildConfig/) {
  currentTask.finalizedBy(extractAllJars)

diff --git a/test-app/app/src/debug/java/com/tns/ErrorReport.java b/test-app/app/src/debug/java/com/tns/ErrorReport.java
@@ -318,6 +318,7 @@ private class Pager extends FragmentStatePagerAdapter {
 
  int tabCount;
 
+ @SuppressWarnings("deprecation")
  public Pager(FragmentManager fm, int tabCount) {
  super(fm);
  this.tabCount = tabCount;

diff --git a/test-app/app/src/main/java/com/tns/DefaultExtractPolicy.java b/test-app/app/src/main/java/com/tns/DefaultExtractPolicy.java
@@ -15,6 +15,8 @@
 import android.content.pm.PackageManager;
 import android.content.pm.PackageManager.NameNotFoundException;
 
+import androidx.core.content.pm.PackageInfoCompat;
+
 import com.tns.Logger;
 import com.tns.ExtractPolicy;
 import com.tns.FileExtractor;
@@ -67,9 +69,9 @@ public String getAssetsThumb(Context context) {
  private String generateAssetsThumb(Context context) {
  try {
  PackageInfo packageInfo = context.getPackageManager().getPackageInfo(context.getPackageName(), 0);
- int code = packageInfo.versionCode;
+ long code = PackageInfoCompat.getLongVersionCode(packageInfo);
  long updateTime = packageInfo.lastUpdateTime;
- return String.valueOf(updateTime) + "-" + String.valueOf(code);
+ return updateTime + "-" + code;
  } catch (NameNotFoundException e) {
  logger.write("Error while getting current assets thumb");
  e.printStackTrace();

diff --git a/test-app/app/src/main/java/com/tns/Util.java b/test-app/app/src/main/java/com/tns/Util.java
@@ -11,15 +11,17 @@
 import android.content.pm.PackageManager.NameNotFoundException;
 import android.os.Bundle;
 
+import androidx.core.content.pm.PackageInfoCompat;
+
 public final class Util {
  private Util() {
  }
 
  public static String getDexThumb(Context context) throws NameNotFoundException {
  PackageInfo packageInfo = context.getPackageManager().getPackageInfo(context.getPackageName(), 0);
- int code = packageInfo.versionCode;
+ long code = PackageInfoCompat.getLongVersionCode(packageInfo);
  long updateTime = packageInfo.lastUpdateTime;
- return String.valueOf(updateTime) + "-" + String.valueOf(code);
+ return updateTime + "-" + code;
  }
 
  public static boolean isDebuggableApp(Context context) {

diff --git a/...va/org/nativescript/staticbindinggenerator/generating/writing/impl/MethodsWriterImpl.java b/...va/org/nativescript/staticbindinggenerator/generating/writing/impl/MethodsWriterImpl.java
@@ -2,11 +2,13 @@
 
 import org.apache.bcel.generic.Type;
 import org.nativescript.staticbindinggenerator.DefaultValues;
+import org.nativescript.staticbindinggenerator.Generator;
 import org.nativescript.staticbindinggenerator.Writer;
 import org.nativescript.staticbindinggenerator.generating.parsing.methods.ReifiedJavaMethod;
 import org.nativescript.staticbindinggenerator.generating.writing.MethodsWriter;
 import org.nativescript.staticbindinggenerator.naming.BcelNamingUtil;
 
+import java.util.Arrays;
 import java.util.List;
 
 public class MethodsWriterImpl implements MethodsWriter {
@@ -228,7 +230,16 @@ private void writeIfStatementBeginning(String condition) {
  writer.write(CLOSING_ROUND_BRACKET_LITERAL);
  }
 
+ private void writeSuppressDepricationsToWritier() {
+ writer.writeln("@SuppressWarnings( \"deprecation\" )");
+ }
+
  private void writeMethodSignature(ReifiedJavaMethod method) {
+ boolean isDeprecated = Arrays.stream(method.getMethod().getAttributes()).anyMatch(x -> x.getName().equals("Deprecated"));
+ if(isDeprecated) {
+ writeSuppressDepricationsToWritier();
+ }
+
  writer.write(getMethodVisibilityModifier(method));
  writer.write(SPACE_LITERAL);
  writer.write(method.getOwnGenericArgumentsDeclaration());