Skip to content

Commit

Permalink
fix: inspector
Browse files Browse the repository at this point in the history
  • Loading branch information
triniwiz committed Apr 8, 2024
1 parent 5aaac57 commit 967df00
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test-app/runtime/src/main/cpp/JsV8InspectorClient.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -290,12 +290,10 @@ void JsV8InspectorClient::inspectorSendEventCallback(const FunctionCallbackInfo<
Local<v8::String> arg = args[0].As<v8::String>();
std::string message = ArgConverter::ConvertToString(arg);

/*
JEnv env;
// TODO: Pete: Check if we can use a wide (utf 16) string here
JniLocalRef str(env.NewStringUTF(message.c_str()));
env.CallStaticVoidMethod(instance->inspectorClass_, instance->sendMethod_, instance->connection_, (jstring) str);
*/

// TODO: ios uses this method, but doesn't work on android
// so I'm just sending directly to the socket (which seems to work)
Expand Down

0 comments on commit 967df00

Please sign in to comment.