Skip to content

Invalidate V8 DateTime cache on timezone changes #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

darind
Copy link
Collaborator

@darind darind commented Apr 30, 2018

Related to #961.

Added new flag handleTimeZoneChanges to app/package.json which invalidates V8 cache when the timezone is changed:

{
    "android": {
        "v8Flags": "--expose_gc",
        "handleTimeZoneChanges": true
    },
    "main": "app.js",
    "name": "tns-template-hello-world",
    "version": "4.0.0"
}

Because this functionality is not a common requirement for most apps, the default value for the flag is false.

@darind
Copy link
Collaborator Author

darind commented Apr 30, 2018

test

@vtrifonov vtrifonov merged commit c7fd3ba into master Apr 30, 2018
@vtrifonov vtrifonov deleted the darind/timezone-changes-notifier branch April 30, 2018 14:02
@darind darind modified the milestone: 4.1.0 Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants