Kddimitrov/livesync improvements #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run ci |
1 similar comment
|
run ci |
darind
approved these changes
Jul 13, 2018
|
run ci |
KristianDD
force-pushed
the
kddimitrov/livesync-improvements
branch
from
07b6a5e to
5986159
Compare
|
run ci |
Close socket on error. Send error data on output. Fix error codes messages.
KristianDD
force-pushed
the
kddimitrov/livesync-improvements
branch
from
b3b82e2 to
84751be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve LiveSync socket implementation and switch it on
Description
Add hash check to operation header and file content.
Add 1 byte for size of the length of fileName and fileContent
Add timeout to socket connection
Start LiveSync in Error Activity
Does your commit message include the wording below to reference a specific issue in this repo?
Implements #932
Related Pull Requests
Will be added once created
Does your pull request have unit tests?
Not currently