Skip to content

Restore DOM and Network callback handlers #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Mar 23, 2023

Description

This restores the JS functions that were used to implement the DOM and Network inspector domains. The functions do nothing, but they are present so that using the corresponding UI features in the inspector doesn't crash.

Related Pull Requests

Does your pull request have unit tests?

No tests included; there's currently no framework for automated tests of the devtools inspector. Test this by attaching the inspector and using functionality in the DOM and Network tabs.

This restores the JS functions that were used to implement the DOM and
Network inspector domains. The functions do nothing, but they are present
so that using the corresponding UI features in the inspector doesn't
crash.
@cla-bot cla-bot bot added the cla: yes label Mar 23, 2023
@edusperoni edusperoni merged commit bc933c8 into NativeScript:feature/v8-10.3.22-perf Mar 24, 2023
@ptomato ptomato deleted the dom-network-callback-handlers branch March 24, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants