Skip to content

fix: pull js stack trace from wrapped NativeScriptExceptions #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2023
Merged

fix: pull js stack trace from wrapped NativeScriptExceptions #1774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8955800
fix: pull js stack trace from wrapped NativeScriptExceptions
rigor789 Jul 12, 2023
3b1c66c
feat: keep unwrapping exceptions if necessary
rigor789 Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions test-app/runtime/src/main/java/com/tns/Runtime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,11 +283,14 @@ private static String getStackTraceOnly(String content) {
}

public static String getJSStackTrace(Throwable ex) {
if (ex instanceof NativeScriptException) {
return ((NativeScriptException) ex).getIncomingStackTrace();
} else {
return null;
Throwable cause = ex;
while(cause != null) {
if(cause instanceof NativeScriptException) {
return ((NativeScriptException) cause).getIncomingStackTrace();
}
cause = cause.getCause();
}
return null;
}

public static String getStackTraceErrorMessage(Throwable ex) {
Expand Down